Only output CD read failure traceback in debug mode #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes the log cleaner, as most of times CD read error is due to CD not inserted.
Without debug mode, output looks like:
```
E: 16:58:00 Error while reading b'/dev/sr1': cannot open device `/dev/sr1'
```
With debug mode:
```
D: 16:58:17 Reading CD using device: b'/dev/sr1'
E: 16:58:17 Error while reading b'/dev/sr1': cannot open device `/dev/sr1'
E: 16:58:17 Traceback (most recent call last):
File "./picard/util/thread.py", line 47, in run
result = self.func()
File "./picard/disc.py", line 55, in read
raise e
File "./picard/disc.py", line 50, in read
disc = discid.read(device)
File "/home/zas/.virtualenvs/picard2/lib/python3.5/site-packages/discid/disc.py", line 55, in read
disc.read(device, features)
File "/home/zas/.virtualenvs/picard2/lib/python3.5/site-packages/discid/disc.py", line 152, in read
raise DiscError(self._get_error_msg())
discid.disc.DiscError: cannot open device `/dev/sr1'
```
samj1912
approved these changes
Jan 19, 2018
samj1912
reviewed
Jan 19, 2018
| self.id = disc.id | ||
| self.submission_url = disc.submission_url | ||
| except discid.disc.DiscError as e: | ||
| log.error("Error while reading %r: %s" % (device, str(e))) |
There was a problem hiding this comment.
Any reason we are using %r here?
There was a problem hiding this comment.
It causes logs like
E: 16:58:17 Error while reading b'/dev/sr1': cannot open device `/dev/sr1'
There was a problem hiding this comment.
I didn't want to bother encodings etc...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes the log cleaner, as most of times CD read error is due to CD not inserted.
Without debug mode, output looks like:
With debug mode: