python-telegram-bot: init at 9.0.0 #34015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build python2Packages.python-telegram-bot python3Packages.python-telegram-bot |
There was a problem hiding this comment.
Success for system: x86_64-linux
running build_ext
patching script interpreter paths in /nix/store/lql5d2803ayadha33fp0j117g0r6lhmq-python3.6-python-telegram-bot-9.0.0
checking for references to /tmp/nix-build-python3.6-python-telegram-bot-9.0.0.drv-0 in /nix/store/lql5d2803ayadha33fp0j117g0r6lhmq-python3.6-python-telegram-bot-9.0.0...
----------------------------------------------------------------------
Ran 0 tests in 0.000s
OK
/nix/store/pkp39m33rkyg6g5kvkdgnyqaf33kkx5f-python2.7-python-telegram-bot-9.0.0
/nix/store/lql5d2803ayadha33fp0j117g0r6lhmq-python3.6-python-telegram-bot-9.0.0
There was a problem hiding this comment.
Success for system: x86_64-darwin
Requirement already satisfied: certifi in /nix/store/lp8mqzwf7fiybh0rj3wfs2k06h9m4nni-python3.6-certifi-2017.7.27.1/lib/python3.6/site-packages (from python-telegram-bot==9.0.0)
Installing collected packages: python-telegram-bot
Successfully installed python-telegram-bot-9.0.0
/private/tmp/nix-build-python3.6-python-telegram-bot-9.0.0.drv-0/python-telegram-bot-9.0.0
post-installation fixup
strip is /nix/store/i1zz228nl3bljcbb83fq0rq7lr7nvv4y-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/sbay1c3bm5zp27myrfndybhazh48m28a-python3.6-python-telegram-bot-9.0.0/lib
patching script interpreter paths in /nix/store/sbay1c3bm5zp27myrfndybhazh48m28a-python3.6-python-telegram-bot-9.0.0
/nix/store/64h993iq1lkndhq9035wli6fn1y8msmy-python2.7-python-telegram-bot-9.0.0
/nix/store/sbay1c3bm5zp27myrfndybhazh48m28a-python3.6-python-telegram-bot-9.0.0
There was a problem hiding this comment.
Success for system: aarch64-linux
reading manifest template 'MANIFEST.in'
writing manifest file 'python_telegram_bot.egg-info/SOURCES.txt'
running build_ext
----------------------------------------------------------------------
Ran 0 tests in 0.000s
OK
/nix/store/nfhc259dz9vxpw7f420bnv4mnmbcrpw1-python2.7-python-telegram-bot-9.0.0
/nix/store/jnq986i26ghw34vbzril6pcfnv9j8hmr-python3.6-python-telegram-bot-9.0.0
dotlambda
requested changes
Jan 19, 2018
| buildPythonPackage rec { | ||
| pname = "python-telegram-bot"; | ||
| version = "9.0.0"; | ||
| name = "${pname}-${version}"; |
There was a problem hiding this comment.
No need for name. Will be derived from pname and version.
| sha256 = "0a5b4wfc6ms7kblynw2h3ygpww98kyz5n8iibqbdyykwx8xj7hzm"; | ||
| }; | ||
|
|
||
| propagatedBuildInputs = [ certifi future ]; |
There was a problem hiding this comment.
What about the extras_requires ujson and pysocks?
There was a problem hiding this comment.
If one wants those they can just add those packages to the closure in a Python env.
FRidh
reviewed
Jan 20, 2018
| }; | ||
|
|
||
| propagatedBuildInputs = [ certifi future ]; | ||
| doCheck = !isPy3k; |
There was a problem hiding this comment.
What is the reason for this? Can you include a comment.
There was a problem hiding this comment.
The reason is that 0 tests are run when using Python 2, so it should really be just doCheck = false for both.
But I made one test run by adding pysocks as a dependency. I believe this is possible for the 7 remaining failing tests as well.
There was a problem hiding this comment.
Turns out the tests need network access (obviously). So it should be doCheck = false.
|
The package uses a vendored version of |
dotlambda
approved these changes
Jan 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)