Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix length_score and add tests #802

Merged
merged 1 commit into from Jan 18, 2018
Merged

Fix length_score and add tests #802

merged 1 commit into from Jan 18, 2018

Conversation

mineo
Copy link
Member

@mineo mineo commented Jan 18, 2018

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

In 2f8496e, 1.0 - ... turned into 0.0.

Solution

Fix that.

@mineo
Fix length_score and add tests
c18ae09 
In 2f8496e, 1.0 - ... turned into 0.0. Fix that.
@samj1912 samj1912 merged commit 790a1d6 into metabrainz:master Jan 18, 2018
zas
zas reviewed Jan 18, 2018
View reviewed changes
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mineo : Lol, totally overlook this bit change. Thank you for catching this and adding matching tests ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zas zas zas left review comments

@samj1912 samj1912 samj1912 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mineo @zas @samj1912