Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mathematica: enable installation of localized editions #34014

Merged
merged 1 commit into from Apr 23, 2018

Conversation

mnacamura
Copy link
Contributor

@mnacamura mnacamura commented Jan 18, 2018

Motivation for this change

Mathematica has many localized editions, e.g. Japanese edition, which I want to install.
This PR aims to make it easier to add such localized editions.

For now English (default) and Japanese editions only.
Fill out information in l10ns.nix to add the other localized editions.
Example usage: mathematica.override { lang = "ja"; } derives Japanese edition.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member

veprbl commented Jan 18, 2018

Do you plan to maintain this? If a new version comes out one would have to update both hashes. If I remember correctly, mathematica is quite a big download, and one would have to download all language versions. Perhaps we could fix versions per language, so mathematica-xx could be behind/ahead in version of mathematica-yy.

edit: they actually provide md5 hash on their site, but I don't see how can I change the download language

@mnacamura
Copy link
Contributor Author

@veprbl That's better. I've changed it to maintain version per language.

@veprbl
Copy link
Member

veprbl commented Jan 19, 2018

Looks good to me!

For now English (default) and Japanese editions only.
Fill out information in `l10ns.nix` to add the other localized editions.
Example usage: `mathematica.override { lang = "ja"; }` derives Japanese edition.
@mnacamura
Copy link
Contributor Author

Squashed.

@mnacamura
Copy link
Contributor Author

edit: they actually provide md5 hash on their site, but I don't see how can I change the download language

I'll try asking Wolfram whether we can get checksums of all localized editions.

@matthewbauer matthewbauer merged commit a02d6c9 into NixOS:master Apr 23, 2018
@matthewbauer
Copy link
Member

In the future it would be useful to standardize this. Something like config.locale maybe even defaulting to $LANG.

@mnacamura mnacamura deleted the mathematica-l10n branch June 13, 2018 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants