boomerang: switch to new active fork, cleanup, maintain #34021
Conversation
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "boomerang-${version}"; | ||
| version = "0.3.99-alpha-2016-11-02"; | ||
| version = "0.4.0-alpha-20180118"; |
There was a problem hiding this comment.
Could you keep hyphens in the date? (https://nixos.org/nixpkgs/manual/#sec-package-naming documents that YYYY-MM-DD is the preferred format)
Why are you changing 0.3.99 to 0.4.0? The latest tag is v0.3.99-alpha, so leaving it as is seems appropriate.
There was a problem hiding this comment.
It's the version the code gives itself currently: https://github.com/ceeac/boomerang/blob/dc53653f2374676c07296b4c51eed4ac4eeba127/cmake-scripts/boomerang-version.cmake#L11
Happy to conform with date, wasn't sure how to handle this.
My understanding is that 2018-01-18 (nothing else) is preferred, but didn't want to "break" upgrades by anyone currently having it installed. Will change as you suggest.
pkgs/top-level/all-packages.nix
Outdated
| @@ -807,7 +807,7 @@ with pkgs; | |||
|
|
|||
| borgbackup = callPackage ../tools/backup/borg { }; | |||
|
|
|||
| boomerang = callPackage ../development/tools/boomerang { }; | |||
| boomerang = qt5.callPackage ../development/tools/boomerang { }; | |||
There was a problem hiding this comment.
Please use libsForQt5.callPackage.
There was a problem hiding this comment.
I somehow got it into my head that qt5.callPackage was no preferred over libsForQt5; I'm not sure where this came from, and will of course fix it :).
dtzWill
force-pushed
the
update/boomerang-20180118
branch
from
42d65e9
to
242ec8c
Compare
Fixes many bugs and GUI doesn't have missing icons, etc.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)