python2Packages.legitfs: init at 0.3 #22137

layus · 2017-01-25T16:09:45Z

No description provided.

FRidh

tests aren't run

FRidh · 2017-01-26T08:05:30Z

Also, will you maintain this package?

fastimport supports py3k. Enabling.

layus · 2017-01-26T10:04:48Z

@FRidh I just noticed that version 0.4 was released at the same time as this PR.

This updated version

Has myself as a maintainer.
Uses version 0.4.0
Updates fastimport for py3k support (as legitfs added support for py3k in the meantime).
Still runs no tests, because legitfs has none

globin · 2017-01-26T16:13:43Z

Could you change the message of the first commit python2Packages -> pythonPackages?

FRidh · 2017-01-26T16:28:59Z

Still runs no tests, because legitfs has none

Then it needs doCheck = false; along with a comment stating it doesn't include tests.

layus · 2017-01-30T12:08:45Z

Closing. the updated version does not work properly. I will resubmit later when I get more time to investigate.

@globin, @FRidh : Thanks for the guidelines about formatting & co in pythonPacakges.

layus force-pushed the add-legitfs branch from 6fb761e to f77a3cf Compare January 25, 2017 16:12

FRidh requested changes Jan 26, 2017

View reviewed changes

FRidh added the 6.topic: python label Jan 26, 2017

layus added 2 commits January 26, 2017 10:58

pythonPackages.fastimport: 0.9.4 -> 0.9.6

bde2ac6

fastimport supports py3k. Enabling.

python2Packages.legitfs: init at 0.3

d3f1c7e

layus force-pushed the add-legitfs branch from f77a3cf to d3f1c7e Compare January 26, 2017 10:02

layus closed this Jan 30, 2017

Provide feedback