capstone: fix pkgconfig file generation #21897
Conversation
|
@joepie91, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bennofs, @thoughtpolice and @lethalman to be potential reviewers. |
| @@ -12,6 +12,10 @@ stdenv.mkDerivation rec { | |||
| configurePhase = '' patchShebangs make.sh ''; | |||
| buildPhase = '' ./make.sh ''; | |||
| installPhase = '' env PREFIX=$out ./make.sh install ''; | |||
|
|
|||
| buildInputs = [ | |||
| pkgconfig | |||
There was a problem hiding this comment.
This should be in nativeBuildInputs:
nativeBuildInputs = [ pkgconfig ];
There was a problem hiding this comment.
I can't say I really fully understand the difference between buildInputs and nativeBuildInputs. Could you elaborate?
There was a problem hiding this comment.
This is important for cross-compilation. All build-time dependencies should be specified in nativeBuildInputs.
For example host compiler would be in nativeBuildInputs, while a library linked against the program would be in buildInputs. Pkg-config needs to be run on host, which build the package.
There was a problem hiding this comment.
Ah, I see. Thanks for the explanation :)
Motivation for this change
The generation of pkgconfig
.pcfiles is currently broken, becausepkgconfigisn't being passed to the expression as a dependency. This leads to failures when attempting to build other software that relies on capstone through pkgconfig (eg.edb).This PR fixes that by adding
pkgconfigas a dependency. The buildscript picks it up automatically and correctly generates a.pcfile (which is correctly picked up by other expressions).Note that while I've tested this patch locally, I've tested it differently (namely, by copying the expression to a custom repository and modifying it). I see no reason why it wouldn't work as submitted in this PR, but figured I'd make note of this anyway.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)