git-crecord: init at 20161216.0 #21903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jan 15, 2017
| sha256 = "0v3y90zi43myyi4k7q3892dcrbyi9dn2q6xgk12nw9db9zil269i"; | ||
| }; | ||
|
|
||
| buildInput = with pythonPackages; [ docutils ]; |
There was a problem hiding this comment.
propagatedBuildInputs is usually used for python.
There was a problem hiding this comment.
I tried that as well, but it won't work. I guess buildInputs would suffice here, as docutils is only a built-time dependency, as far as I can see...
Mic92
force-pushed
the
add-git-crecord
branch
from
ae8a38a
to
7adf2ff
Compare
Mic92
reviewed
Jan 15, 2017
| sha256 = "0v3y90zi43myyi4k7q3892dcrbyi9dn2q6xgk12nw9db9zil269i"; | ||
| }; | ||
|
|
||
| propagatedBuildInputs = with pythonPackages; [ docutils ]; |
There was a problem hiding this comment.
the following built on my machine
There was a problem hiding this comment.
Hm. Maybe I made some typo somewhere and misread the error message, sorry! Thank you very much for your effort!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Would like to test this package and maybe use it myself.
I need help though, as I cannot get the
docutilsinto scope while building...Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)