Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tryton: init 4.2.1 #21899

Merged
merged 2 commits into from Jan 15, 2017
Merged

tryton: init 4.2.1 #21899

merged 2 commits into from Jan 15, 2017

Conversation

johbo
Copy link
Contributor

@johbo johbo commented Jan 15, 2017

Motivation for this change

Add a new package Tryton to make the client of the Tryton application platform available via Nix.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@johbo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zimbatm, @zraexy, @edolstra and @FRidh to be potential reviewers.

@@ -4066,6 +4066,8 @@ in

trousers = callPackage ../tools/security/trousers { };

tryton = pythonPackages.tryton;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is not a library, please put it into a separate directory instead of pythonPackages

name = "tryton-${version}";
version = "4.2.1";
src = pkgs.fetchurl {
url = "https://pypi.python.org/packages/58/bc/89419765f262dc772a0a448fe3633dd64b1ad08d185b068910ba70944c0f/tryton-4.2.1.tar.gz";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use mirror:// here: mirror://pypi/t/tryton/${name}.tar.gz

@Mic92 Mic92 changed the title Add Tryton client application tryton: init 4.2.1 Jan 15, 2017
@johbo
Copy link
Contributor Author

johbo commented Jan 15, 2017

Thanks for having a look @Mic92 - Hope I got it into a proper shape now. I noticed that nox-review does explode, is this normal on new packages?

@Mic92 Mic92 merged commit e4c88f5 into NixOS:master Jan 15, 2017
@Mic92
Copy link
Member

Mic92 commented Jan 15, 2017

@johbo sometimes other things break. Your package is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants