Allowing to configure executables for filters (fixes #2615). #2638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwpolska
requested changes
Jan 15, 2017
| @@ -562,6 +562,29 @@ GITHUB_COMMIT_SOURCE = True | |||
| # ".jpg": ["jpegoptim --strip-all -m75 -v %s"], | |||
| # } | |||
|
|
|||
| # The executable for the filter "yui_compressor" from nikola.filters can | |||
There was a problem hiding this comment.
I’d prefer something else (matches how we describe other settings):
# Executable for the "yui_compressor" filter (defaults to 'yui-compressor').
And perhaps name those settings *_EXECUTABLE. With YUI Compressor, we should be prepared to take this:
java -jar ~/yui-compressor.jar
There was a problem hiding this comment.
Since YUI_COMPRESSOR is simply inserted in the command line, it can also be java -jar ~/yui-compressor.jar.
About the naming: I'll adjust that.
There was a problem hiding this comment.
I also adjusted the comments in conf.py.in.
|
|
||
| # The executable for the filter "jpegoptim" from nikola.filters can be | ||
| # configured here: | ||
| # JPEG_OPTIM = 'jpegoptim' |
| @@ -45,6 +45,19 @@ | |||
| from .utils import req_missing, LOGGER | |||
|
|
|||
|
|
|||
| class configurable_filter(object): | |||
There was a problem hiding this comment.
A better name would be _ConfigurableFilter, because we don’t want this to be considered public.
Kwpolska
reviewed
Jan 15, 2017
| @@ -925,6 +926,17 @@ def __init__(self, **config): | |||
| utils.LOGGER.warn('The STORY_INDEX option is deprecated, use PAGE_INDEX instead.') | |||
| self.config['PAGE_INDEX'] = config['STORY_INDEX'] | |||
|
|
|||
| # Configure filters | |||
| for _, actions in self.config['FILTERS'].items(): | |||
There was a problem hiding this comment.
for actions in self.config['FILTERS'].values():
Kwpolska
approved these changes
Jan 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2615.