vimPlugins: add typescript-vim, tsuquyomi #21904
Conversation
|
@instantepiphany, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jagajaga, @garbas and @MarcWeber to be potential reviewers. |
| tsuquyomi = buildVimPluginFrom2Nix { # created by nix#NixDerivation | ||
| name = "tsuquyomi-2017-01-02"; | ||
| src = fetchgit { | ||
| url = "git://github.com/Quramy/tsuquyomi"; |
There was a problem hiding this comment.
Are there additional dependencies needed for this plugin?
There was a problem hiding this comment.
Yes, do I just put vim plugin dependencies in here or packages like node?
|
Yes, my bad I will update the PR. |
|
Tsuquyomi requires vimproc, TypeScript and node. Do I only add vimproc or do I add all of them as dependencies? This is my first PR for nixpkgs. |
|
They require them at runtime or compile time? |
|
Runtime, nothing is needed for compile. It worked fine with this commit checked out. |
|
@jagajaga do only compile dependencies get added to default.nix or runtime as well? |
|
Nothing should be added if that's a runtime dep. |
Motivation for this change
Improving typescript development in neo/vim.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)