h2: init at 1.4.193 #21893
Merged
h2: init at 1.4.193 #21893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jan 15, 2017
|
|
||
| version = "1.4.193"; | ||
|
|
||
| src = fetchurl { |
There was a problem hiding this comment.
fetchzip can be used instead of fetchurl. This would make unpackPhase and unzip unnecessary.
|
@Mic92 using fetchzip instead of fetchurl now |
Mic92
reviewed
Jan 15, 2017
|
|
||
| echo '${h2ToolScript}' > $out/bin/h2tool.sh | ||
|
|
||
| chmod +x $out/bin/*.sh |
There was a problem hiding this comment.
can you also replace the java reference in h2.sh:
substituteInPlace $out/bin/h2.sh --replace "java" "${jre}/bin/java"
|
@Mic92 Fixed the java expression. Thanks for catching that. |
|
Tested successfully. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
h2 is a often used database for jvm development
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)