Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select: fix case when select send executed before select receive, fixed #3862 #3899

Merged
merged 1 commit into from May 18, 2017
Merged

Select: fix case when select send executed before select receive, fixed #3862 #3899

merged 1 commit into from May 18, 2017

Conversation

kostya
Copy link
Contributor

@kostya kostya commented Jan 14, 2017 •
edited

fix for #3862
spec for bug is last, other specs i just added because seems select not tested nice.

@spalladino spalladino requested a review from waj January 16, 2017 16:50
@RX14
Copy link
Contributor

RX14 commented May 18, 2017

Would be great to get this merged, as it's a bugfix.

waj
waj approved these changes May 18, 2017
View reviewed changes
Copy link
Member

@waj waj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bcardiff bcardiff merged commit deef66c into crystal-lang:master May 18, 2017
@bcardiff bcardiff added this to the Next milestone May 18, 2017
@bcardiff
Copy link
Member

Thanks @kostya ! 💚 for the extra specs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waj waj waj approved these changes

Assignees
No one assigned
Labels
kind:bug topic:stdlib:concurrency
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kostya @RX14 @bcardiff @waj @spalladino