xcbuild: 0ab861ab -> 0.1.1 #21895
Merged
xcbuild: 0ab861ab -> 0.1.1 #21895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthewbauer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @copumpkin and @LnL7 to be potential reviewers. |
LnL7
added
6.topic: darwin
|
The linux build fails for me. https://gist.github.com/LnL7/c6c772261a6e87805eada2ad2c736ef8 |
matthewbauer
force-pushed
the
xcbuild-update
branch
from
1ce5a27
to
fae8db2
Compare
|
Fixed with flag. See facebookarchive/xcbuild#221 |
|
There also seems to be a problem with some of the darwin packages that depend on it https://gist.github.com/LnL7/8f6b4714b587549ba23b06c614f6cd32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
These changes fix an issue with building under i686-linux (http://hydra.nixos.org/job/nixpkgs/trunk/xcbuild.i686-linux). I've also added a wrapper for xcode-select so that it detects the pure SDK instead of looking in /Applications/Xcode.app.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)