New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
haskell: add servant sphinx docs to build #21900
Conversation
@Profpatsch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peti, @abbradar and @acowley to be potential reviewers. |
@@ -1,4 +1,4 @@ | |||
{ pkgs }: | |||
{ stdenv, pkgs }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use pkgs.stdenv
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, didn’t know that exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the other hand it’s more explicit that way, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know ... my feeling is that once you expect the entire frickin' package set as an argument, it's kind of silly to add other arguments on top of that. That's why I asked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol, ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here you go
c2e7b69
to
0ef2921
Compare
Next step will be the cabal docs. |
Servant builds its user docs from the
doc/
folder with sphinx. This commit adds them to the package.