Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell: add servant sphinx docs to build #21900

Merged
merged 1 commit into from Jan 16, 2017
Merged

Conversation

Profpatsch
Copy link
Member

Servant builds its user docs from the doc/ folder with sphinx. This commit adds them to the package.

@mention-bot
Copy link

@Profpatsch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peti, @abbradar and @acowley to be potential reviewers.

@@ -1,4 +1,4 @@
{ pkgs }:
{ stdenv, pkgs }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use pkgs.stdenv?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, didn’t know that exists.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the other hand it’s more explicit that way, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know ... my feeling is that once you expect the entire frickin' package set as an argument, it's kind of silly to add other arguments on top of that. That's why I asked.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, ok.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here you go

@Profpatsch
Copy link
Member Author

Profpatsch commented Jan 15, 2017

Next step will be the cabal docs.

@peti peti merged commit ad412ba into NixOS:master Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants