Fix: UNIXServer shouldn't delete path on bind failures #3771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
reviewed
Dec 25, 2016
| raise error | ||
| end | ||
|
|
||
| listen(backlog) do |error| | ||
| close | ||
| close(delete: false) |
There was a problem hiding this comment.
Is there a possibility that the bind call above succeeds and creates the file, but listen fails? I think in this case the file should be deleted, right?
ysbaddaden
force-pushed
the
fix-unix-server-deletes-file-on-bind-failures
branch
from
04b1820
to
f0009cd
Compare
|
@asterite fixed |
|
I forgot to start a review with my pending comment, but @asterite found the issue with listen, too, so I'm ok with this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3764