Remove outdated TODOS #3760
Merged
Remove outdated TODOS #3760
+40
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
force-pushed
the
remove-todos
branch
2 times, most recently
from
295a32f to
07b1bec
Compare
|
@asterite GTG? |
|
@Sija Depends, some crystal binaries for 0.20.3 weren't available at the time of the PR |
|
@asterite builds on |
|
@Sija Yeah, then we basically can't merge this because all next commits will always fail and we won't immediately know if it's because of this or something else. Let's wait until all builds are green. |
Sija
force-pushed
the
remove-todos
branch
3 times, most recently
from
a908562 to
9d46a9b
Compare
|
@asterite CI just turned green :) |
|
Great! It seems the rebuild triggered by @jhass did work :-) |
|
@asterite ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.