Darwin gtk2/pygtk quartz backend #21382

johbo · 2016-12-23T21:41:13Z

Motivation for this change

I wanted to use a pygtk based application on darwin and noticed that it relied on the X11 backend of gtk which leads to trouble in multi screen setups (lost windows out of screen). Using the quartz backend also leads to a nicer display of the applications.

This Pull Request adjust GTK2 based on the work from #20658. I aimed to keep the changes to the GTK2 Derivation as close as possible to the other PR. The main change is that I added the CoreText dependencies to cairo and pango, so that fonts are actually visible.

Due to #12346 starting the applications still needs a twist by using something like DYLD_FRAMEWORK_PATH=/System/Library/Frameworks.

Things done

Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- Linux
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

mention-bot · 2016-12-23T21:41:15Z

@johbo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat, @jwiegley and @edolstra to be potential reviewers.

johbo · 2016-12-23T21:42:41Z

Regarding the binaries I've tested gtk-demo and pygtk-demo, those worked fine.

johbo · 2016-12-24T00:34:54Z

I've done some more experiments, it appears to me as if ApplicationServices should go into the propagatedBuildInputs of cairo.

vbgl · 2016-12-24T13:16:23Z

This breaks gnome2.gtksourceview. It now reports the following error.

checking for IGE_MAC... no
configure: error: Package requirements (ige-mac-integration) were not met:

No package 'ige-mac-integration' found

You may need to package some extra libraries (https://github.com/rhult/ige-mac-integration).

johbo · 2016-12-24T15:04:04Z

Uh, it might cause a few more issues like that I guess. I'll try to add ige-mac-integration and make things work.

johbo · 2016-12-25T00:05:28Z

@vbgl think I got the gtksourceview issue figured out. Do you have any suggestions how I could best check how much this change might affect other packages?

vbgl · 2016-12-25T17:54:00Z

Indeed, gtksourceview now builds. But this PR breaks coqide, inkscape, zim: they build but crash on startup.

LnL7 · 2016-12-26T23:55:10Z

@johbo nox-review and #19045 (comment)

johbo · 2016-12-27T10:35:05Z

Hmm, it seems that all gtk2 based applications will suffer from #12346 until we get that sorted. I wonder if it would be better to make this gtk2 change opt-in and build by default for X11 until that's solved.

matthewbauer

These changes look good! It probably should be merged into staging first though.

Once this gets into master I can work on merging #20658 again.

matthewbauer · 2017-01-05T23:33:40Z

pkgs/desktops/gnome-2/desktop/gtksourceview/default.nix

-    gettext];
+
+  patches = optionals stdenv.isDarwin [
+    ./0001-Change-IgeMacIntegration-to-GtkOSXApplication.patch


Can you use fetchpatch for these?

Thanks for the hint, was not yet aware of it. I'll try to use it for both patches.

matthewbauer · 2017-01-05T23:34:18Z

pkgs/development/libraries/librsvg/default.nix

@@ -1,5 +1,5 @@
 { lib, stdenv, fetchurl, pkgconfig, glib, gdk_pixbuf, pango, cairo, libxml2, libgsf
-, bzip2, libcroco, libintlOrEmpty
+, bzip2, libcroco, libintlOrEmpty, darwin


This shouldn't be needed.

This helps so that fonts are properly rendered in gtk when used with the backend "quartz".

Had to add this so that it was able to parse the headers from the frameworks.

johbo · 2017-01-07T16:36:12Z

I'll rebase this quickly

Noticed that it caused depending packages to fail, like librsvg, imagemagiv, graphviz.

Had to pick two commits as patches from the repository which update the dependency ige-mac-integration to gtk-mac-integration.

matthewbauer · 2017-01-07T20:18:02Z

cc @LnL7 @copumpkin

LnL7 · 2017-01-07T20:55:48Z

Looks like about ~1400 packages will rebuild, I think that's still ok to do on master.

LnL7 added the 6.topic: darwin Running or building packages on Darwin label Dec 23, 2016

johbo force-pushed the darwin-pygtk-quartz-backend branch from 92d8be4 to f2a44b4 Compare December 23, 2016 21:47

matthewbauer requested changes Jan 5, 2017

View reviewed changes

This was referenced Jan 5, 2017

GIMP on Darwin (use Quartz) #20658

Merged

Transmission: Darwin support #21720

Merged

johbo added 5 commits January 7, 2017 17:31

cairo: Add CoreText for darwin

bbdca63

This helps so that fonts are properly rendered in gtk when used with the backend "quartz".

pango: Add darwin frameworks for fond rendering

354c91d

librsvg: Add framework ApplicationServices for darwin

9f31633

gtk2: Use quartz backend on darwin

5a572f8

pygtk: Add flag -ObjC for darwin

8f7adff

Had to add this so that it was able to parse the headers from the frameworks.

johbo force-pushed the darwin-pygtk-quartz-backend branch from 61fc9d7 to ade978d Compare January 7, 2017 16:35

johbo force-pushed the darwin-pygtk-quartz-backend branch from ade978d to bbaf7fe Compare January 7, 2017 18:18

johbo and others added 3 commits January 7, 2017 19:21

cairo: Add ApplicationServices as propagatedBuildInput

0f67005

Noticed that it caused depending packages to fail, like librsvg, imagemagiv, graphviz.

gtk-mac-integration: init at 2.0.8

ea053ca

gtksourceview: Add gtk-mac-integration for darwin

f025d2c

Had to pick two commits as patches from the repository which update the dependency ige-mac-integration to gtk-mac-integration.

johbo force-pushed the darwin-pygtk-quartz-backend branch from bbaf7fe to f025d2c Compare January 7, 2017 18:22

LnL7 approved these changes Jan 7, 2017

View reviewed changes

matthewbauer approved these changes Jan 7, 2017

View reviewed changes

LnL7 merged commit 826d6aa into NixOS:master Jan 7, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Darwin gtk2/pygtk quartz backend #21382

Darwin gtk2/pygtk quartz backend #21382

johbo commented Dec 23, 2016 •

edited

mention-bot commented Dec 23, 2016

johbo commented Dec 23, 2016

johbo commented Dec 24, 2016

vbgl commented Dec 24, 2016

johbo commented Dec 24, 2016

johbo commented Dec 25, 2016

vbgl commented Dec 25, 2016

LnL7 commented Dec 26, 2016

johbo commented Dec 27, 2016

matthewbauer left a comment

matthewbauer Jan 5, 2017

johbo Jan 7, 2017

matthewbauer Jan 5, 2017

johbo commented Jan 7, 2017

matthewbauer commented Jan 7, 2017

LnL7 commented Jan 7, 2017

Darwin gtk2/pygtk quartz backend #21382

Darwin gtk2/pygtk quartz backend #21382

Conversation

johbo commented Dec 23, 2016 • edited

Motivation for this change

Things done

mention-bot commented Dec 23, 2016

johbo commented Dec 23, 2016

johbo commented Dec 24, 2016

vbgl commented Dec 24, 2016

johbo commented Dec 24, 2016

johbo commented Dec 25, 2016

vbgl commented Dec 25, 2016

LnL7 commented Dec 26, 2016

johbo commented Dec 27, 2016

matthewbauer left a comment

Choose a reason for hiding this comment

matthewbauer Jan 5, 2017

Choose a reason for hiding this comment

johbo Jan 7, 2017

Choose a reason for hiding this comment

matthewbauer Jan 5, 2017

Choose a reason for hiding this comment

johbo commented Jan 7, 2017

matthewbauer commented Jan 7, 2017

LnL7 commented Jan 7, 2017

johbo commented Dec 23, 2016 •

edited