jdk8: Allow selection of specific update+build #21392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spacekitteh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @obadz, @NeQuissimus and @wkennington to be potential reviewers. |
LnL7
reviewed
Dec 24, 2016
| , jdksha ? "1kw4h3j93cvnlzh0vhj4xxdm90bk7hfg6kpqk09x0a12whh2ww3h" | ||
| , jaxwssha ? "0wrj3jyv3922m3pxfg0i9c3ap71b0rass7swvhi996c029rd12r7" | ||
| , jaxpsha ? "0b743mygzdavdd59l98b3l6a03dihs4ipd1xlpkacy778wzpr59d" | ||
| , nashornsha ? "10wkshhzj15wvx7i53dbkwi85f4fbbxi26zphr5b6daf3ib0hind" |
There was a problem hiding this comment.
Do these versions belong together? It's probably a bit nicer to put all these in an attribute set, if it doesn't really make sense to override them separately.
It would also make it easier to add a fetchOpenJDK helper function.
There was a problem hiding this comment.
+1 for an attribute set with well known update-build pair and a default value on the latest.
Attribute set could be like :
supportedBuilds = {
"u122b4" = {
update = "122", build = "04",
jdk8sha = "", langtoolssha ? "0hhsm23mxvjxmf0jxlhm57s203k88s8xbmk71l8zlnjsz88ni4gx", ...
},
u122b3 = {
update = "122", build = "03",
jdk8sha = "", langtoolssha = "", ...
},
}
|
My motivation for this has been removed. If anyone wants to do this they can, but I have no reason to anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
To be able to work around specific bugs.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)