Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tdesktop: 0.10.19 -> 1.0.0 #21821

Closed
wants to merge 2 commits into from
Closed

tdesktop: 0.10.19 -> 1.0.0 #21821

wants to merge 2 commits into from

Conversation

loskutov
Copy link
Contributor

Motivation for this change

Update tdesktop to the stable 1.0.0 version

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@loskutov, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar and @garbas to be potential reviewers.

@abbradar
Copy link
Member

Does it build for you? I have this when trying:

building path(s) ‘/nix/store/32p78l86cz96zfbxnbwcchp6k81kmgp5-telegram-desktop-1.0.0’
unpacking source archive /nix/store/r3f3f9mp7acm2lcn0imc9diqzzypawiw-tdesktop-v1.0.0-src
source root is tdesktop-v1.0.0-src
applying patch /nix/store/16p3pj8xyl8y4ndjdi9ayazf95aaasw1-telegram-desktop-99bb051/aur-fixes.diff
patching file Telegram/SourceFiles/platform/linux/linux_libs.cpp
patching file Telegram/SourceFiles/platform/linux/linux_libs.h
patching file Telegram/SourceFiles/stdafx.cpp
patching file Telegram/gyp/Telegram.gyp
Hunk #1 succeeded at 79 (offset 1 line).
patching file Telegram/gyp/qt.gypi
patching file Telegram/gyp/telegram_linux.gypi
Hunk #2 FAILED at 42.
1 out of 2 hunks FAILED -- saving rejects to file Telegram/gyp/telegram_linux.gypi.rej

builder for ‘/nix/store/wcddn44614j8lx237b8lp0xfw93psgjy-telegram-desktop-1.0.0.drv’ failed with exit code 1
error: build of ‘/nix/store/wcddn44614j8lx237b8lp0xfw93psgjy-telegram-desktop-1.0.0.drv’ failed

Supposedly you need to also update patch from AUR. FWIW I'm testing atop current unstable channel (I don't think it can influence a bad patch however).

@loskutov
Copy link
Contributor Author

Oops looks like I've built the old version of the derivation :/

@abbradar abbradar closed this in c94c266 Jan 12, 2017
@abbradar
Copy link
Member

Pushed with a fix to make the build succeed. Please test that the package compiles and runs next time ~_^. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@loskutov @mention-bot @abbradar @joachifm