[wip] Add pyobjc to nixpkgs #21829
Closed
[wip] Add pyobjc to nixpkgs #21829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthewbauer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pikajude, @copumpkin, @acowley and @FRidh to be potential reviewers. |
FRidh
requested changes
Jan 12, 2017
| }; | ||
|
|
||
| frameworks = rec { # 3.1.1 corresponds to SDK 10.9 because we only have CF 10.9 | ||
| Accounts = buildPyObjcFramework "Accounts" "3.1.1" "1jgasyz88mhl58ks1k06qqxd6ifzbkcjkir6ny0hjr6vc07lk99h" [ Cocoa ]; |
There was a problem hiding this comment.
How do you deal with updates of these packages? Do you edit these hashes manually or automatically?
| sha256 = "1fp58318n7rabxakis5cw4z2lcyimsp167hlfl6y0mvf7zx8dxai"; | ||
| }; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
can you add a reason why you disable tests
| sha256 = "0pmaxrvx2vnlgsdlbzqr32v2j0n81n07x4xrc2nigfdnrxsxvcc2"; | ||
| }; | ||
|
|
||
| doCheck = false; |
|
status update? |
|
I've gotten stuck on it and the reason I needed pyobjc (for Transmission) is not really necessary now that we have the GTK backend working on macOS. It was never working correctly anyway. Anybody can work off of this if they will need it. |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This adds the "pyobjc" python module to nixpkgs. It is only available for OS X, however. Some of the frameworks failed with 10.9 SDK, so they have been disabled.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)