New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PICARD-872: Optionnaly use language from release for tracks without work language #526
Conversation
…ithout work language
How does this work for tracks with a language set on the work, but when
track/recording relationships are disabled?
…On Sun, Jan 1, 2017 at 2:40 PM, yaymeh ***@***.***> wrote:
…ithout work language (ui / turned off by default)
------------------------------
You can view, comment on, or merge this pull request online at:
#526
Commit Summary
- Add optional metadata setting: Use language from release for tracks
without work language
File Changes
- *M* picard/mbxml.py
<https://github.com/metabrainz/picard/pull/526/files#diff-0> (2)
- *M* picard/ui/options/metadata.py
<https://github.com/metabrainz/picard/pull/526/files#diff-1> (3)
- *M* picard/ui/ui_options_metadata.py
<https://github.com/metabrainz/picard/pull/526/files#diff-2> (7)
- *M* test/test_mbxml.py
<https://github.com/metabrainz/picard/pull/526/files#diff-3> (1)
- *M* ui/options_metadata.ui
<https://github.com/metabrainz/picard/pull/526/files#diff-4> (8)
Patch Links:
- https://github.com/metabrainz/picard/pull/526.patch
- https://github.com/metabrainz/picard/pull/526.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#526>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAExnJfzL5RflKwULNmrXHwxf8tcLKOgks5rN6y0gaJpZM4LYtiF>
.
|
If the "use track relationship" option is inactive, tracks don't get a language from the work (as far as I can tell); so in that case, with the "language from release" option activated, all tracks will get the release language. Was that what you meant? Should that be mentioned explicitly? I couldn't think of a shorter option name that describes it better. Maybe "Use release language as default for tracks"? |
You need to link this PR to a matching Picard issue at https://tickets.metabrainz.org |
In the model of MB, "Use the release language as default for tracks" makes sense to me. |
You mean as text at https://github.com/metabrainz/picard/pull/526/files#diff-493c462bfbbfdff6021c7fe1c9cbaa40R108 ? |
Just noticed that the folksonomy option text says: "Fall back", so I used "fallback" - it's probably most accurate? Added jira ticket: |
To fall back is a verb, fallback is a noun. So it depends on context, see discussion at http://english.stackexchange.com/questions/90549/difference-between-fallback-and-fall-back |
Sorry, I don't understand what you're trying to tell me... if there's still something wrong with the UI text, I can't find it. Or do I have to rebase / squash the commits or something? |
@mineo ^^ ?
Nope, that's ok for me, but this PR will have to wait after 1.4.0 release, strings are frozen until release. |
With that:
...I meant the "needs more work" tag. If the link to:
...was a clue, I didn't get it. What exactly needs more work? |
Note that I don't think this should be merged into Picard's core: https://tickets.metabrainz.org/browse/PICARD-872?focusedCommentId=41975&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-41975 And since @samj1912 at least wants to move Picard 2.0 in a more modular direction, it seems like going down the wrong path to introduce something like this to the 1.4.x branch as a core feature rather than as a plugin. |
I agree that this needs to be a plugin rather than an inclusion to the core picard code. Please feel free to rework this PR as a plugin and submit to the Plugin Repo. As such I am closing this PR for now. |
Actually, it can easily be done in a tagging script. |
This.
|
(ui / turned off by default)
https://tickets.metabrainz.org/browse/PICARD-872