Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PICARD-872: Optionnaly use language from release for tracks without work language #526

Closed
wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 1, 2017

@mineo
Copy link
Member

mineo commented Jan 1, 2017 via email

@ghost
Copy link
Author

ghost commented Jan 1, 2017

If the "use track relationship" option is inactive, tracks don't get a language from the work (as far as I can tell); so in that case, with the "language from release" option activated, all tracks will get the release language.

Was that what you meant? Should that be mentioned explicitly? I couldn't think of a shorter option name that describes it better. Maybe "Use release language as default for tracks"?

@zas
Copy link
Collaborator

zas commented Jan 7, 2017

You need to link this PR to a matching Picard issue at https://tickets.metabrainz.org

@mineo
Copy link
Member

mineo commented Jan 7, 2017

In the model of MB, "Use the release language as default for tracks" makes sense to me.

@zas
Copy link
Collaborator

zas commented Jan 7, 2017

In the model of MB, "Use the release language as default for tracks" makes sense to me.

You mean as text at https://github.com/metabrainz/picard/pull/526/files#diff-493c462bfbbfdff6021c7fe1c9cbaa40R108 ?
I agree.

@ghost
Copy link
Author

ghost commented Jan 7, 2017

Just noticed that the folksonomy option text says: "Fall back", so I used "fallback" - it's probably most accurate?

Added jira ticket:
https://tickets.metabrainz.org/browse/PICARD-872

@zas
Copy link
Collaborator

zas commented Jan 11, 2017

Just noticed that the folksonomy option text says: "Fall back", so I used "fallback" - it's probably most accurate?

To fall back is a verb, fallback is a noun. So it depends on context, see discussion at http://english.stackexchange.com/questions/90549/difference-between-fallback-and-fall-back

@ghost
Copy link
Author

ghost commented Jan 20, 2017

Sorry, I don't understand what you're trying to tell me... if there's still something wrong with the UI text, I can't find it.

Or do I have to rebase / squash the commits or something?

@zas zas changed the title Add optional metadata setting: Use language from release for tracks w… PICARD-872: Optionnaly use language from release for tracks without work language Jan 20, 2017
@zas
Copy link
Collaborator

zas commented Jan 20, 2017

Sorry, I don't understand what you're trying to tell me... if there's still something wrong with the UI text, I can't find it.

@mineo ^^ ?

Or do I have to rebase / squash the commits or something?

Nope, that's ok for me, but this PR will have to wait after 1.4.0 release, strings are frozen until release.

@ghost
Copy link
Author

ghost commented Jan 25, 2017

With that:

Sorry, I don't understand what you're trying to tell me... if there's still something wrong with the UI text, I can't find it.

...I meant the "needs more work" tag.

If the link to:

http://english.stackexchange.com/questions/90549/difference-between-fallback-and-fall-back

...was a clue, I didn't get it.

What exactly needs more work?

@zas zas added 1.4.1 and removed Needs more work labels Jan 26, 2017
@Freso
Copy link
Member

Freso commented Feb 14, 2017

Note that I don't think this should be merged into Picard's core: https://tickets.metabrainz.org/browse/PICARD-872?focusedCommentId=41975&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-41975

And since @samj1912 at least wants to move Picard 2.0 in a more modular direction, it seems like going down the wrong path to introduce something like this to the 1.4.x branch as a core feature rather than as a plugin.

@samj1912
Copy link
Collaborator

I agree that this needs to be a plugin rather than an inclusion to the core picard code. Please feel free to rework this PR as a plugin and submit to the Plugin Repo. As such I am closing this PR for now.

@Sophist-UK
Copy link
Contributor

Actually, it can easily be done in a tagging script.

@phw
Copy link
Member

phw commented Oct 2, 2019

Actually, it can easily be done in a tagging script.

This.

$if($not(%language%),$set(language,%_releaselanguage%))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants