borgbackup: cleanup inputs #21555
Merged
borgbackup: cleanup inputs #21555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tox/detox are removed; they are used to test multiple python implementations in parallel, which isn't really appropriate for a Nix install check. Also, because these were added to the propagated build inputs, lots of unnecessary stuff ended up in the resulting closure. Note that removing tox does not imply tests are not run; they never were to begin with; this is a separate issue. This fixes NixOS#16171 Also, for "correctness" ordinary build-time dependencies are added to `buildInputs`; only inputs that are to be added to the python path are added to `propagatedBuildInputs`.
|
My backup still works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #16171. See commit message for details. Tested basic functionality.