rubber: 1.3 -> 1.4 #21565
rubber: 1.3 -> 1.4 #21565
Conversation
|
@peterhoeg, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ttuegel, @FRidh and @Fuuzetsu to be potential reviewers. |
| stdenv.mkDerivation rec { | ||
| name = "rubber-1.3"; | ||
| let | ||
| pypkgs = python2Packages; |
There was a problem hiding this comment.
Please use either python2Packages or pythonPackages instead of a custom variable.
There was a problem hiding this comment.
The idea was to avoid having to specify python2Packages 3 times. If we need to move to python 3 at some point, that means changing only one variable.
There was a problem hiding this comment.
That would be a simple search & replace. In any case, you can still use the let expression but don't use another name; everywhere pythonPackages is used so stick with it.
| }; | ||
|
|
||
| buildInputs = [ python2Packages.python texinfo ]; | ||
| nativeBuildInputs = [ python2Packages.wrapPython ]; | ||
| nativeBuildInputs = [ pypkgs.wrapPython ]; |
There was a problem hiding this comment.
wrapPython is provided by buildPythonApplication
| buildInputs = [ python2Packages.python texinfo ]; | ||
| nativeBuildInputs = [ python2Packages.wrapPython ]; | ||
| nativeBuildInputs = [ pypkgs.wrapPython ]; | ||
| propagatedBuildInputs = [ pypkgs.python texinfo ]; |
|
@FRidh, I ripped out the |
|
Thanks! |
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)