astroid: init at 0.6 #21558
Closed
astroid: init at 0.6 #21558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was necessary for astroid to work with gmime, and I thought it would be generally useful.
|
@bdimcheff, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat, @edolstra and @aristidb to be potential reviewers. |
bdimcheff
force-pushed
the
add-package-astroid
branch
from
8d1a831
to
be20be0
Compare
Mic92
reviewed
Jan 1, 2017
| src = fetchurl { | ||
| url = "https://github.com/astroidmail/astroid/archive/v${version}.tar.gz"; | ||
| sha256 = "1d1ivn3vaddlz6bxcgifw4n5jaf7d8y35kk1a457gdq9n1mq87mr"; | ||
| }; |
There was a problem hiding this comment.
Please use fetchFromGitHub here with rev = version;
|
merged in 0890ce6 |
|
thanks @Mic92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Added astroid, a gtk+ interface for the notmuch mail system. Note that I had to compile gmime with introspection as well. I could parameterize this if necessary, but it seemed like it might be useful to be enabled generally.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)