Skip to content

Commit

Permalink
docker: deprecate socketActivation option
Browse files Browse the repository at this point in the history
  • Loading branch information
@Mic92
Mic92 committed Jan 1, 2017
1 parent d5f8652 commit ce99e34
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions nixos/modules/virtualisation/docker.nix
View file
Expand Up @@ -130,4 +130,8 @@ in
}
]);

imports = [
(mkRemovedOptionModule ["virtualisation" "docker" "socketActivation"] "This option was removed in favor of starting docker at boot")
];

}

2 comments on commit ce99e34

@bjornfor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is socket activation deprecated? Is it an upstream decision? (AFAIK, socket activation is a good thing.)

@Mic92
Copy link
Member Author

@Mic92 Mic92 commented on ce99e34 Jan 1, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjornfor it is not an option anymore to not use socket activation, docker will be always socket activated. But we start the docker daemon at boot by default to allow restart=always containers to start at boot. There is an option, which does not start docker at boot.

Please sign in to comment.