-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decreased coverage with 9.1.7.0 snapshot #4404
Comments
@donv Not seeing this on macos at least:
Java was:
|
Ha! Fun thing... I just talked to @colszowka (creator of simplecov) a while back about JRuby support etc. and he asked if I'd be willing to join the team and be the JRuby support person and officially support JRuby. We both agreed that chances of this requiring any work/of any regressions would be super low 😄 Anyhow, the simplecov specs also fail on jruby-head now and it seems to be exactly the integration tests with different reported coverage values. I can also confirm the decreased coverage on the repo @donv mentioned:
@enebo there is a switch in the repo that checks if JRuby has Happy to help in any way to debug this and get it back working for 9.1.7.0 as this is a critical bug/regression for me personally :D Anyhow, happy holidays to all of you and thanks for all you do 🌟 |
@PragTob ah heh...I definitely did not run with --debug so that is why I did not see the issue. Thanks for pointing that out. |
Bisected this to f9d704c ... |
so JRuby must potentially dead-locks in a debugging session so that simplecov reports correct coverage ... |
at_exit seems to be used her - I'm not in the simplecov code base that much yet and time is somewhat limited, if you gave me general directions of what'd be the problem/potential fix I could try fixing that :) also @enebo thanks for bisecting and all the work :) 💚 |
The setup command is used when upgrading RubyGems, and pristine is a clean reinstall. Neither honor the settings for "install" or "update" so we need to force them too. See jruby#4404
jruby 9.1.7.0-SNAPSHOT (2.3.1) 2016-12-21 946befd Java HotSpot(TM) 64-Bit Server VM 25.112-b16 on 1.8.0_112-b16 +jit [darwin-x86_64]
When testing https://travis-ci.org/donv/capybara-screenshot-diff I get a very low coverage percentage using simplecov and JRuby 9.1.7.0-SNAPSHOT.
I get the expected coverage percentage of 86% when using any MRI version since 2.1 and JRuby 9.1.2.0, 9.1.5.0, and 9.1.6.0.
To reproduce:
The text was updated successfully, but these errors were encountered: