Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
8f046ce
commit 28c0656
Showing
2 changed files
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -192,7 +192,8 @@ self: super: { | |
then dontCheck (overrideCabal super.hakyll (drv: { | ||
testToolDepends = []; | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
domenkozar
Author
Member
|
||
})) | ||
else super.hakyll; | ||
# https://github.com/jaspervdj/hakyll/issues/491 | ||
else dontCheck super.hakyll; | ||
|
||
# Heist's test suite requires system pandoc | ||
heist = overrideCabal super.heist (drv: { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have a question that's unrelated to your commit, but maybe you can help me understand it anyway. The line above emties
testToolDepends
, presumably to avoid the dependency onutillinux
. Now, when the test suite is disabled by means ofdontCheck
, then those dependencies shouldn't be evaluated anyway, right? So in my mind, messing withtestToolDepends
on Darwin is unnecessary. Can you confirm that this is the case? Because if it where, when this override could be simplified even further.