Disable tests for zope.configuration on Python3.6 #21672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is related to an issue I opened a while ago. It was only partially solved in setuptools at the time. Am I correct that it was only the tests that failed but the package did actually function? |
FRidh
reviewed
Jan 5, 2017
| @@ -27230,6 +27230,8 @@ EOF | |||
| sha256 = "1x9dfqypgympnlm25p9m43xh4qv3p7d75vksv9pzqibrb4cggw5n"; | |||
| }; | |||
|
|
|||
| doCheck = pythonOlder "3.6"; | |||
|
Fails on 3.5, too. |
|
Yeah, it's a regression in setuptools :/
pypa/setuptools#912
Sent from mobile. Please excuse my brevity.
…On 19 Jan 2017 12:02 p.m., "Robin Gloster" ***@***.***> wrote:
Fails on 3.5, too.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21672 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAt8w7Wi0cBsLG2dlMr6UShG-56ajbcsks5rT1C3gaJpZM4Lbf42>
.
|
|
@FRidh I think I'm having the same issue while trying to package mailman3 with "nested modules" (e.g. |
|
uups, think I duplicated this one https://github.com/NixOS/nixpkgs/pull/23038/files#diff-2afbba83e1b14f9e0c304c769831a0e2R27596 Problem exists on python3 in general, tried python3.4, 3.5 and 3.6, all showed the issue for zope configuration. |
|
It happens indeed on multiple Python 3.x versions. Because we already disabled tests on Python 3.x I'm closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
zopefoundation/zope.configuration#16
pypa/setuptools#912
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)