Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed py3.3 test failures. #192

Merged
merged 2 commits into from Jan 15, 2017
Merged

Fixed py3.3 test failures. #192

merged 2 commits into from Jan 15, 2017

Conversation

apollo13
Copy link
Contributor

No description provided.

@apollo13
Copy link
Contributor Author

Oh crap, I just realized that mark.skipif only works on functions/classes, will see if pytest lets me skip a whole testmodule

If there is just one test in the module, this could be moved down to the
test. But for now travis-ci should get back to green with minimal
changes.
@coveralls
Copy link

Coverage Status

Coverage increased (+3.9%) to 76.656% when pulling 4579de8 on apollo13:py3.3 into f1abe5d on circuits:master.

@prologic prologic merged commit 2924dbb into circuits:master Jan 15, 2017
@apollo13 apollo13 deleted the py3.3 branch January 15, 2017 20:49
@coveralls
Copy link

coveralls commented Jan 15, 2017

Coverage Status

Coverage increased (+1.3%) to 74.041% when pulling 155906f on apollo13:py3.3 into f1abe5d on circuits:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 74.041% when pulling 155906f on apollo13:py3.3 into f1abe5d on circuits:master.

spaceone pushed a commit to spaceone/circuits that referenced this pull request Feb 12, 2017
* Fixed py3.3 test failures.

* Properly skipped whole test modules.

If there is just one test in the module, this could be moved down to the
test. But for now travis-ci should get back to green with minimal
changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants