Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: 1.8.0 -> 1.8.1 #21921

Merged
merged 2 commits into from Jan 16, 2017
Merged

vscode: 1.8.0 -> 1.8.1 #21921

merged 2 commits into from Jan 16, 2017

Conversation

jansuchomel
Copy link
Contributor

Motivation for this change

New version. I've also updated the .desktop file generation, because there shouldn't be new lines in the Comment section.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@jansuchomel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @xwvvvvwx, @uralbash and @mucaho to be potential reviewers.

Mic92 added a commit that referenced this pull request Jan 16, 2017
@Mic92 Mic92 merged commit 489e6ea into NixOS:master Jan 16, 2017
@7c6f434c 7c6f434c merged commit a6e183b into NixOS:master Jan 16, 2017
@Mic92
Copy link
Member

Mic92 commented Jan 16, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants