kdeWrapper: Fix XDG_DATA_DIRS/XDG_CONFIG_DIRS mixup. #21918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.../share` directories go with `XDG_DATA_DIRS`, and `.../etc/xdg` directories go with `XDG_CONFIG_DIRS`. These were accidentally reversed. See https://userbase.kde.org/KDE_System_Administration/Environment_Variables#freedesktop.org_Compliance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sharedirectories go withXDG_DATA_DIRS, andetc/xdgdirectories go withXDG_CONFIG_DIRS. These were accidentally reversed.See this KDE wiki page for example.
Motivation for this change
This solves my problem with Spectacle not having any items in the
Export Image... > More Online Servicesmenu, such as the Imgur uploader. I had previously mentioned this here but I don't think there's a dedicated issue.I figured out that the plugin loader relied on a
kservices5directory and bystraceing Spectacle, I noticed that it was looking in thekdeWrapper"env" package foretc/xdg/kservices5but I knew the real path wasshare/kservices5, and then the accidental reversal became clear.Since the problem was actually in
kdeWrapper, this has a good chance of fixing issues in other KDE5 packages that I'm not aware of.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)