Postgrey #21586
Merged
Postgrey #21586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 2, 2017 15:10
|
The option renames will be painful for any existing users, but I admit that it makes slightly more sense, the way you did it. Hoping that I'm the only existing user, a tentative +1 from me. |
|
You could add entries like those in https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/rename.nix to smoothe things out. |
|
@bendlas are you okay with this? I have no stake in this module. |
|
LGTM, thanks for the compat options! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The postgrey module was rather rudimentary
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)configuration.nixdoes not showsocketnicely, I worked around that by making sure the default and example cover all options available in both submodules – is there a prettier solution?