Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

puddletag: get rid of pypkgs variable #21587

Merged
merged 1 commit into from Jan 2, 2017
Merged

puddletag: get rid of pypkgs variable #21587

merged 1 commit into from Jan 2, 2017

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Ref #21565, we do not use pypkgs as a shorthand for pythonPackages.

Cc: @FRidh

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh FRidh merged commit 93cabca into NixOS:master Jan 2, 2017
@peterhoeg peterhoeg deleted the f/puddletag branch January 3, 2017 00:47
@peterhoeg peterhoeg restored the f/puddletag branch January 3, 2017 01:09
@peterhoeg peterhoeg deleted the f/puddletag branch March 1, 2017 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @FRidh