Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 8b03a76e6153
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: c882915351ac
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Dec 31, 2016

  1. Strongswan: enable rdrand and aes-ni only on X86 

    Strongswan fails to compile on armv7l-linux with `--enable-aesni` and  `--enable-rdrand` enabled. Errors are thrown about impossible constraints in asm (`--enable-rdrand`) or about gcc getting unknown command line parameters about aes (`--enable-aesni`). The options only makes sense on X86_64 processors.

The rdrand plugin is designed for Ivy Bridge processors:

> High quality / high performance random source using the Intel rdrand instruction found on Ivy Bridge processors

The aes-ni plugin also only exists on X86 processors (which have the AES instruction set)

Tested with a local override. The change triggers a (successful) rebuild on my X86_64 system. On armv7-linux this change fixes build errors.

See: 
https://wiki.strongswan.org/issues/337
    @FPtje
    FPtje committed Dec 31, 2016
    Configuration menu
    Copy the full SHA
    9c61571 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2017

  1. Merge pull request #21548 from FPtje/patch-2 

    Strongswan: enable rdrand and aes-ni only on X86
    @7c6f434c
    7c6f434c committed Jan 2, 2017
    Configuration menu
    Copy the full SHA
    c882915 View commit details
    Browse the repository at this point in the history