Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asterisk: 13.6.0 -> 13.13.1 #22142

Merged
merged 2 commits into from Jan 26, 2017
Merged

asterisk: 13.6.0 -> 13.13.1 #22142

merged 2 commits into from Jan 26, 2017

Conversation

yorickvP
Copy link
Contributor

Motivation for this change

asterisk was marked broken in 655017d. This version is the latest release on the same LTS branch and does not have that CVE.

(cc: @grahamc)

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested execution of all binary files (usually in ./result/bin/) (some of them depend on asterisk being in the $PATH)
  • Tested usage on my server. It didn't get worse than it was before.
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@yorickvP, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fpletz, @zimbatm and @vcunat to be potential reviewers.

fpletz
fpletz approved these changes Jan 26, 2017
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for stepping up as maintainer and testing the package!

Does it make sense to backport this to 16.09?

@grahamc
Copy link
Member

grahamc commented Jan 26, 2017

👍 I'll merge in the AM. @fpletz this is being merged to 16.09 directly, as unstable has a newer version of asterisk.

@grahamc
Copy link
Member

grahamc commented Jan 26, 2017

Note: someone else could merge this too, but I'm not merging now because I haven't reviewed the code.

@grahamc grahamc merged commit 73bd95d into NixOS:release-16.09 Jan 26, 2017
@grahamc
Copy link
Member

grahamc commented Jan 26, 2017

Thank you!

@yorickvP yorickvP deleted the asteriskupd branch January 29, 2017 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@DerTim1 DerTim1 DerTim1 approved these changes

Assignees
No one assigned
Labels
1.severity: security 8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yorickvP @mention-bot @grahamc @fpletz @DerTim1 @pSub