Fix LICENSE and add NOTICE file #3903

makenowjust · 2017-01-16T11:49:53Z

See Applying the Apache License, section "Applying the license to new software". It says:

To apply the ALv2 to a new software distribution, include one copy of the license text by copying the file:

http://www.apache.org/licenses/LICENSE-2.0.txt

into a file called LICENSE in the top directory of your distribution. If the distribution is a jar or tar file, try to add the LICENSE file first in order to place it at the top of the archive. This covers the collective licensing for the distribution.

So I update LICENSE to Apache License 2.0 content. (Old LICENSE is the content of Apache License 2.0's Appendix, which is for file header. This contains the phrase "this file". We can understand Apache 2.0 is applied to only LICENSE file, not project. It is ambiguous, I think.)

Also I added Runtime Library Exception to the Apache 2.0 License section to LICENSE, because Apache License 2.0 effects the binary using the library. In short, when we distribute the binary using Crystal standard library, we must contains the copy of Apache License 2.0 and copyright of Crystal. I think it is confusing and not so important.

Finally, I added NOTICE file, which explains licenses of the libraries used by Crystal. I think such a file creation is responsibility of the library user, and Crystal repository contains some JS/CSS library. We should explain about them, especially Octicons files didn't include copyright information.

And bonus point, GitHub will detect our project's license if this pull request is merged, like:

I wish you don't think this pull request is blah.

I want you to add Apache License 2.0 header to all source codes in this repository, but this change is too large, so I couldn't decide apply it.

References:

Swift's LICENSE I was heavily inspired Runtime Library Exception to the Apache 2.0 License by this.
Julia's LICENSE
Apache Software Foundation's repositories

Thanks!

ysbaddaden · 2017-01-16T13:26:07Z

NOTICE.md

+    - [LGPLv3](https://www.gnu.org/licenses/lgpl-3.0.en.html)
+  * [bdwgc](http://www.hboehm.info/gc/)
+    - [MIT](https://opensource.org/licenses/MIT)
+  * [pkg-config](https://www.freedesktop.org/wiki/Software/pkg-config/)


pkg-config isn't linked, but the external executable is used if present.

ysbaddaden · 2017-01-16T13:27:17Z

NOTICE.md

+  * [pkg-config](https://www.freedesktop.org/wiki/Software/pkg-config/)
+    - [GPLv3](https://www.gnu.org/licenses/gpl-3.0.en.html)
+
+Crystal standard library uses these libraries, which have their own licenses:


Maybe:

Parts of the Crystal standard library link to the following libraries, ...

No. "Parts of the Crystal standard library" sounds good, but "link" is really no thanks. Because, if Crystal standard library links to the GPL libraries in fact, we must license it GPL. Howeber, Crystal standard library work and exist independent of some GPL library (readline and GMP). I prefer "use" to "link".

ysbaddaden · 2017-01-16T13:28:16Z

NOTICE.md

+  * PCRE
+  * libevent2
+  * libiconv
+  * bdwgc


Maybe duplicate the link + license/link from above?

david50407 · 2017-01-18T16:23:18Z

NOTICE.md

@@ -0,0 +1,65 @@
+# Crystal Programmig Language


Programming

makenowjust · 2017-01-20T02:22:06Z

@waj @ysbaddaden Updated.

I want you to add Apache License 2.0 header to all source codes in this repository, but this change is too large, so I couldn't decide apply it.

How do you think about it? I think it isn't really important that copying the content written in "APPENDIX" of Apache 2.0, but we should clarify each source codes licensed by Apache 2.0. So I think, for example, inserting such a comment to file header is effective enough:

# This file is a part of Crystal project, which is licensed by Apache License 2.0 (See LICENSE.)

ysbaddaden · 2017-01-20T09:28:05Z

@makenowjust I assume there is a reason for the in-file license header to be so detailed, so either we put it verbatim, or we just don't.

j8r · 2018-12-20T21:43:04Z

Any update?

Shemeikka · 2020-04-03T19:10:33Z

Hi,

It seems that this has been forgotten for a long time. Would be a good to have a proper license for the project. These changes look good to me.

Could we get an update for this pull request?

straight-shoota · 2020-04-08T10:17:15Z

NOTICE.md

+    - MIT
+  * [LibYAML](http://pyyaml.org/wiki/LibYAML)
+    - MIT
+  * [readline](https://cnswww.cns.cwru.edu/php/chet/readline/rltop.html)


This is no longer linked.

makenowjust · 2020-04-08T11:49:58Z

This PR is created three years ago. Maybe many updates are needed. I will check it tomorrow.

makenowjust · 2020-04-09T14:04:55Z

git rebase to HEAD is done, update copyright year and update NOTOCE.md file style.

NOTICE.md

Co-Authored-By: Sijawusz Pur Rahnama <sija@sija.pl>

bcardiff

I want @waj approval (here or IRL) on this before merging. Thanks!

makenowjust · 2020-04-11T04:48:00Z

GitHub detects this project's license is Apache-2.0 correctly.
Thanks!

ysbaddaden reviewed Jan 16, 2017

View reviewed changes

spalladino requested a review from waj January 16, 2017 17:48

david50407 reviewed Jan 18, 2017

View reviewed changes

straight-shoota reviewed Apr 8, 2020

View reviewed changes

straight-shoota requested a review from bcardiff April 8, 2020 10:17

makenowjust added 4 commits April 9, 2020 22:33

Fix LICENSE and add NOTICE file

75abfbe

Fix NOTICE.md

e70f86a

Update copyright year

711e0c5

Fix NOTICE file format

10fb57b

makenowjust force-pushed the fix/license branch from 4c91113 to 10fb57b Compare April 9, 2020 13:53

Update playground libraries link

f64ba7e

RX14 approved these changes Apr 9, 2020

View reviewed changes

Sija reviewed Apr 9, 2020

View reviewed changes

NOTICE.md Outdated Show resolved Hide resolved

straight-shoota added kind:feature topic:infrastructure labels Apr 9, 2020

straight-shoota reviewed Apr 9, 2020

View reviewed changes

NOTICE.md Outdated Show resolved Hide resolved

makenowjust and others added 2 commits April 10, 2020 19:58

Use reference link in NOTICE.md

a9943b5

Update NOTICE.md

5ccc844

Co-Authored-By: Sijawusz Pur Rahnama <sija@sija.pl>

bcardiff approved these changes Apr 10, 2020

View reviewed changes

waj approved these changes Apr 10, 2020

View reviewed changes

waj merged commit b250ada into crystal-lang:master Apr 10, 2020

makenowjust deleted the fix/license branch April 10, 2020 19:41

carlhoerberg pushed a commit to carlhoerberg/crystal that referenced this pull request Apr 29, 2020

Fix LICENSE and add NOTICE file (crystal-lang#3903)

076f571

bcardiff added this to the 0.35.0 milestone May 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix LICENSE and add NOTICE file #3903

Fix LICENSE and add NOTICE file #3903

makenowjust commented Jan 16, 2017

ysbaddaden Jan 16, 2017

ysbaddaden Jan 16, 2017

makenowjust Jan 17, 2017 •

edited

makenowjust Jan 20, 2017

ysbaddaden Jan 16, 2017

david50407 Jan 18, 2017

makenowjust Jan 20, 2017

makenowjust commented Jan 20, 2017

ysbaddaden commented Jan 20, 2017

j8r commented Dec 20, 2018

Shemeikka commented Apr 3, 2020

straight-shoota Apr 8, 2020

makenowjust commented Apr 8, 2020

makenowjust commented Apr 9, 2020 •

edited

bcardiff left a comment

makenowjust commented Apr 11, 2020

Fix LICENSE and add NOTICE file #3903

Fix LICENSE and add NOTICE file #3903

Conversation

makenowjust commented Jan 16, 2017

ysbaddaden Jan 16, 2017

Choose a reason for hiding this comment

ysbaddaden Jan 16, 2017

Choose a reason for hiding this comment

makenowjust Jan 17, 2017 • edited

Choose a reason for hiding this comment

makenowjust Jan 20, 2017

Choose a reason for hiding this comment

ysbaddaden Jan 16, 2017

Choose a reason for hiding this comment

david50407 Jan 18, 2017

Choose a reason for hiding this comment

makenowjust Jan 20, 2017

Choose a reason for hiding this comment

makenowjust commented Jan 20, 2017

ysbaddaden commented Jan 20, 2017

j8r commented Dec 20, 2018

Shemeikka commented Apr 3, 2020

straight-shoota Apr 8, 2020

Choose a reason for hiding this comment

makenowjust commented Apr 8, 2020

makenowjust commented Apr 9, 2020 • edited

bcardiff left a comment

Choose a reason for hiding this comment

makenowjust commented Apr 11, 2020

makenowjust Jan 17, 2017 •

edited

makenowjust commented Apr 9, 2020 •

edited