libvirt: Allow more complex network setups #585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, since bridges can be defined at the network level (https://libvirt.org/formatnetwork.html#examplesBridge) (thanks nekroze@freenode), the whole of deployment.libvirtd.interfaces might not be needed. |
|
I'm splitting this PR since I'm not sure about the interfaces part. See #586 for the IP detection thing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for more complex network setups in libvirt, notably bridging and static IPs.
It removes the hacky way to get static MACs. People who need a static MAC address can set it in the interface config in deployment.libvirtd.interfaces.
It also adds different methods for detecting the VM's IP address, in case DHCP is not used for example.