rubocop: init at 0.47.0 #21934
Merged
rubocop: init at 0.47.0 #21934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimbatm
reviewed
Jan 16, 2017
|
|
||
| bundlerEnv rec { | ||
| name = "rubocop-${version}"; | ||
| version = "0.47.0"; |
There was a problem hiding this comment.
Instead of this it's also possible to use pname = "rubocop";. This will automatically extract the version from the gemset.nix and hide any bin that are not part of the main "rubocop" package.
|
|
||
| gemfile = ./Gemfile; | ||
| lockfile = ./Gemfile.lock; | ||
| gemset = ./gemset.nix; |
There was a problem hiding this comment.
There is a new option called gemdir = ./.; that can be used to automatically infer all these files.
There was a problem hiding this comment.
@zimbatm how about throwing a deprecation message for the old variant?
|
👍 thanks @zimbatm! Will make life easier for future packages I might need to build :) |
Use gemdir and pname as suggested by @zimbatm Fix silly typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
To add the rubocop linter as a global package (for support with text editors that don't know how to use bundler or docker or nix-shell)
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)