Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

picard: fix compilation and remove unused buildInputs #21711

Merged
merged 2 commits into from Jan 6, 2017
Merged

picard: fix compilation and remove unused buildInputs #21711

merged 2 commits into from Jan 6, 2017

Conversation

mimame
Copy link
Member

@mimame mimame commented Jan 6, 2017

Motivation for this change

Fix compilation and remove unused buildInputs. This pull request fixes bug #21696

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@mimadrid, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aszlig, @FRidh and @ehmry to be potential reviewers.

@pSub pSub merged commit 99c8e8e into NixOS:master Jan 6, 2017
@pSub pSub mentioned this pull request Jan 6, 2017
Closed
@mimame mimame deleted the fix/picard branch May 15, 2017 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: python 8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mimame @mention-bot @pSub @FRidh