Transmission: Darwin support #21720
Merged
Transmission: Darwin support #21720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthewbauer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat, @johbo and @edolstra to be potential reviewers. |
matthewbauer
force-pushed
the
transmission
branch
from
4922bdf
to
189daac
Compare
LnL7
added
6.topic: darwin
|
I'll mark this as WIP for now since it depends on the other changes. |
This flag can be used to enable systemd daemon support in transmission.
This sets "--disable-mac" so that we use GTK instead of the macOS backend. The macOS backend should work but currently it breaks with xcbuild.
matthewbauer
force-pushed
the
transmission
branch
from
189daac
to
6695954
Compare
|
#21382 seems to be merged, is this PR ready to merge now? |
LnL7
approved these changes
Jan 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This adds a Transmission support of Darwin. Like my other Darwin App PR #20658, it depends on #21382 to work correctly.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)