Fixed example codes #3851
Merged
Fixed example codes #3851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiha
commented
Jan 6, 2017
| @@ -39,7 +39,7 @@ module HTML | |||
| # require "html" | |||
| # | |||
| # io = IO::Memory.new | |||
| # HTML.escape("Crystal & You", io) # => "Crystal & You" | |||
There was a problem hiding this comment.
I don't know this breaking change is good. But this is a current spec.
|
Nice, thank you! I think it would make sense to include your tool https://github.com/maiha/comment-spec.cr in the compiler itself. Then we can generate these specs and run them in travis, to make sure they all pass. And also, any project could use that to make sure example code works and is correct. I guess something like |
|
@asterite Definitely! It should be checked in PR phase. |
|
If we make the playground generate a dump with the values as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed recent inconsistencies where they almost comes from
each : Nil.Specs 127 (103 successes, 4 failures, 20 pending)Specs 127 (107 successes, 0 failures, 20 pending)powered by https://github.com/maiha/crystal-examples