rclone: 1.33 -> 1.35 #21598
rclone: 1.33 -> 1.35 #21598
Conversation
|
@danielfullmer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dguibert, @zimbatm and @zraexy to be potential reviewers. |
| }; | ||
|
|
||
| goDeps = ./deps.nix; | ||
|
|
||
| meta = { |
There was a problem hiding this comment.
You could use meta = with stdenv.lib; ... to make it a little less verbose.
| @@ -1,219 +0,0 @@ | |||
| # This file was generated by go2nix. | |||
There was a problem hiding this comment.
What happened to all the dependencies?
There was a problem hiding this comment.
As far as I can tell, this file is no longer necessary. The rclone project pins and includes its own go dependencies under the vendor subdirectory. See https://github.com/ncw/rclone/tree/master/vendor
Moreover, go2nix has been updated to take the vendor subdirectory into account when computing deps.nix. See go2nix#21 In fact, running go2nix on this project now produces an empty deps.nix file.
There was a problem hiding this comment.
Ah that explains it, was just curious.
danielfullmer
force-pushed
the
rclone-1.35
branch
from
89e918a
to
76d37ce
Compare
Motivation for this change
Updated rclone to 1.35. Note that the go dependencies are included under the vendor/ directory of the source files. So, there is no need to include them in the deps.json file, as discussed in go2nix#21
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)