cjdns service: optional extraHosts #21592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 60ded3f. We want to make this optional instead.
Enabling this incurs a heavy eval-time cost, but it's a nice usability enhancement; satisfy both concerns by making it optional (default false).
|
@joachifm, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ehmry, @spacekitteh and @edolstra to be potential reviewers. |
7 tasks
|
@joachifm Thanks a lot for your help and sorry I haven't managed to
implement it before you over the holidays.
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #21249 that preserves history.