Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libbitcoin #21594

Merged
merged 3 commits into from Jan 3, 2017
Merged

libbitcoin #21594

merged 3 commits into from Jan 3, 2017

Conversation

chris-martin
Copy link
Contributor

Motivation for this change

Provides the bx program (#18644)

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7
Copy link
Member

LnL7 commented Jan 3, 2017

It looks like all of these should work on darwin, you should add it to the platforms.

@LnL7
Copy link
Member

LnL7 commented Jan 3, 2017

Yep, everything works fine https://gist.github.com/LnL7/84eb84b2cac42a818e13a3d7334d6385.

@chris-martin
Copy link
Contributor Author

Okay, I'll change it

@LnL7 LnL7 merged commit 0a5ccc1 into NixOS:master Jan 3, 2017
@chris-martin chris-martin deleted the pr/libbitcoin branch January 3, 2017 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants