chase: init at 0.5.2 #21590
chase: init at 0.5.2 #21590
Conversation
| @@ -0,0 +1,26 @@ | |||
| { stdenv, fetchurl ,pkgconfig, libatomic_ops , boehmgc , ... }: | |||
There was a problem hiding this comment.
Please use a closed parameter list (no ...)
| { stdenv, fetchurl ,pkgconfig, libatomic_ops , boehmgc , ... }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "chase_0.5.2.orig"; |
There was a problem hiding this comment.
Please move .orig to src.url
|
|
||
| buildInputs = [ pkgconfig libatomic_ops boehmgc ] ; | ||
| src = fetchurl { | ||
| url = "http://ftp.stw-bonn.de/debian/pool/main/c/chase/${name}.tar.gz"; |
There was a problem hiding this comment.
Please use mirror://debian
| ''; | ||
| homepage = "https://qa.debian.org/developer.php?login=rotty%40debian.org"; | ||
| license = stdenv.lib.licenses.gpl2Plus; | ||
| maintainers = [ "Maurizio Di Pietro" ]; |
There was a problem hiding this comment.
Please add a proper entry to maintainers.
| @@ -4359,6 +4359,10 @@ in | |||
|
|
|||
| which = callPackage ../tools/system/which { }; | |||
|
|
|||
| chase = callPackage ../tools/system/chase { | |||
| inherit boehmgc; | |||
There was a problem hiding this comment.
callPackage is supposed to fill in all missing parameter from the enclosing scope; this explicit inherit ought to be unnecessary here.
| { stdenv, fetchurl ,pkgconfig, libatomic_ops , boehmgc }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "chase_0.5.2"; |
There was a problem hiding this comment.
The convention is to separate the version and name with a dash.
This is actually necessary to make nix-env -u work properly. http://nixos.org/nixpkgs/manual/#sec-package-naming
There was a problem hiding this comment.
The file on the debian repo seperates name and version with a "_" , so i used it .
Thank you.
| makeFlags = [ "-e" ]; | ||
| makeFlagsArray="LIBS=-lgc"; | ||
|
|
||
| meta = { |
There was a problem hiding this comment.
you could use meta = with stdenv.lib; here so you don't need the full qualified attributes anymore
|
Merged in e0878ce note I collapsed your commits in to one with the text "chase: init at xxx". I also fixed the hyphen in the name. Thank you! |
|
One other thing -- I had to rename your entry in maintainers.nix because it needs to match your github name. I did that in fa89f84. |
|
Hi graham, |
|
Oh, can you create a new pr with a fix? |
|
Ok fixed the hyphen issue and avoided fully qualified attribute names as you suggested |
|
well Graham Christensen already fixed it in the nixos repo directly ,
should work right now.
2017-01-04 11:31 GMT+01:00 Daiderd Jordan <notifications@github.com>:
… Oh, can you create a new pr with a fix?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#21590 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AXuc4p3B3Xxm_qveoSdIPZVtcsEzkqksks5rO3UFgaJpZM4LZHwE>
.
|
Janik-Haag
added
the
12. first-time contribution
Motivation for this change
NixOs handles different versions of software contemporary installed on a NixOs installation.
Dispatching is done via symlinks.
"Chase" automatically resolves to the last target of a chain of symlinks avoiding looping.
I think its a valuable tool for any NixOs admin and is good company for "which".
Things done
Added chase under pkgs/tools/system/chase
Its empowers "which" that is installed in the same pkgs path
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)