stdenv: bootstrap cmake and python on darwin #21596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LnL7
added
1.severity: mass-darwin-rebuild
6.topic: darwin
|
@LnL7, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dtzWill, @vcunat and @gridaphobe to be potential reviewers. |
This was referenced Jan 2, 2017
FRidh
reviewed
Jan 2, 2017
| ''; | ||
| license = stdenv.lib.licenses.psfl; | ||
| platforms = stdenv.lib.platforms.all; | ||
| maintainers = with stdenv.lib.maintainers; [ lnl7 chaoflow domenkozar ]; |
There was a problem hiding this comment.
I suppose you or darwin maintainers are going to maintain this expression?
There was a problem hiding this comment.
Yes, I separated this so changes in the default python expression won't necessarily cause a rebuild of the entire darwin world.
FRidh
approved these changes
Jan 2, 2017
LnL7
commented
Jan 2, 2017
| @@ -5176,9 +5176,13 @@ in | |||
| inherit (stdenvAdapters) overrideCC; | |||
| }; | |||
|
|
|||
| llvmPackages_37 = callPackage ../development/compilers/llvm/3.7 { | |||
| llvmPackages_37 = callPackage ../development/compilers/llvm/3.7 ({ | |||
There was a problem hiding this comment.
I'm pretty sure I should do this somewhere else but I couldn't get it working in the stdenv bootstrap phases.
|
Merging straight to master because of 125fa15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Use bootstrap versions of cmake and python to get some dependencies like curl, libarchive and sqlite out of the stdenv.
/cc @copumpkin
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
./result/bin/)