Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enpass backport #21436 to Release 16.09 #21493

Closed
wants to merge 1 commit into from
Closed

enpass backport #21436 to Release 16.09 #21493

wants to merge 1 commit into from

Conversation

RonnyPfannschmidt
Copy link
Contributor

@RonnyPfannschmidt RonnyPfannschmidt commented Dec 29, 2016 •
edited

Motivation for this change

backport #21436

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Dec 29, 2016

Two things:

  1. Backports should be cherry-picked with -x
  2. What is the purpose of this update?

Typically these are what we backport:

# What to backport:

 - Security patches which aren't major updates
 - If a security patch is a major upgrade, try and find patches to our
   current version which accomplish the same goal. Apply the major
   update to master, and the patches to stable.
 - Bug fixes to applications which, again, aren't major updates.
   Generally be cautious about these.
 - Any updates when the current stable version is utterly broken. A
   key example of this is Spotify, who regularly breaks their old
   versions.
 - Extremely security-sensitive software, in particular Chrome,
   Chromium, Firefox, Thunderbird, and of course the kernel.

@RonnyPfannschmidt
Copy link
Contributor Author

oh, i see, i missed that bit and i am sorry, i was a bit over-zealous there
thanks for pointing it out

@RonnyPfannschmidt RonnyPfannschmidt deleted the release-16.09-enpass-backport branch December 29, 2016 22:14
@grahamc
Copy link
Member

grahamc commented Dec 29, 2016

It is okay :) It looks like a nice update ... I was almost hoping for an excuse for backporting.

@grahamc
Copy link
Member

grahamc commented Dec 30, 2016 •
edited

@RonnyPfannschmidt do you use the browser extensions? I'm not able to connect them (with firefox.)

@grahamc
Copy link
Member

grahamc commented Dec 30, 2016

I backported this fix (thank you) to get the latest fixes and updates on such sensitive software, and to get this patch as well: #21082

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RonnyPfannschmidt @grahamc