Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qemu: fix CVE-2016-9911, CVE 2016-9921 and 2016-9922 #21482

Closed
wants to merge 2 commits into from

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Dec 28, 2016

Motivation for this change

fix CVE-2016-9911

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@nlewo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fpletz, @edolstra and @matthewbauer to be potential reviewers.

@grahamc
Copy link
Member

grahamc commented Dec 28, 2016

cc #21457

@nlewo nlewo mentioned this pull request Dec 28, 2016
23 tasks
@grahamc
Copy link
Member

grahamc commented Dec 28, 2016

Does this, by chance, also resolve CVE-2016-9921, and CVE-2016-9922 ?

@nlewo
Copy link
Member Author

nlewo commented Dec 28, 2016

@grahamc no ;(
But I'll have a look these ones.

@nlewo nlewo changed the title qemu: fix CVE-2016-9911 qemu: fix CVE-2016-9911, CVE 2016-9921 and 2016-9922 Dec 28, 2016
@nlewo
Copy link
Member Author

nlewo commented Dec 28, 2016

Regarding CVE 2016-9921 and 2016-9922, I don't understand why there are 2 CVEs since it seems they report the same issue fixed by the same patch...

@grahamc
Copy link
Member

grahamc commented Dec 29, 2016

I agree, your changes LGTM. Thank you!

@grahamc
Copy link
Member

grahamc commented Dec 29, 2016

I've merged this in to my roundup branch, this will auto-close when I merge it in to master. Thank you! :)

@grahamc grahamc closed this Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants