Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shellinabox 2.19 -> 2.20 #21486

Closed
wants to merge 1 commit into from
Closed

Conversation

dbalan
Copy link
Contributor

@dbalan dbalan commented Dec 29, 2016

should fix shellinabox vulnerabilities in #21457

Motivation for this change

New release.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

should fix shellinabox vulnarabilities from NixOS#21457
@mention-bot
Copy link

@dbalan, thanks for your PR! By analyzing the history of the files in this pull request, we identified @lihop, @tomberek and @grwlf to be potential reviewers.

@grahamc
Copy link
Member

grahamc commented Dec 29, 2016

LGTM I've merged this in to my roundup branch, the PR will be closed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants